[libcxx-commits] [PATCH] D121276: [CMake] Include runtimes test suites in check-all

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a comment.

In D121276#3370263 <https://reviews.llvm.org/D121276#3370263>, @ldionne wrote:

> When I apply your patch locally, run a bootstrapping build and then invoke `check-all`, for some reason I still see the `check-runtimes` target being run before all the other targets. I assume this is not intended?

I see it as well, let me debug this.

In D121276#3370012 <https://reviews.llvm.org/D121276#3370012>, @ldionne wrote:

> Interesting -- so you basically write the test dependencies, parameters and test suites i.e. everything that `check-runtimes` contains into a file:
>
>   add_lit_target(check-runtimes
>       "Running all regression tests"
>       ${RUNTIMES_LIT_TESTSUITES}
>       PARAMS ${RUNTIMES_LIT_PARAMS}
>       DEPENDS ${RUNTIMES_LIT_DEPENDS}
>       ARGS ${RUNTIMES_LIT_EXTRA_ARGS}
>   )
>
> and then you add that directly to `check-all` from the main build.

We use the same approach to also collect components from the compiler-rt build, see https://github.com/llvm/llvm-project/blob/c3a7627cacc6cbe2301a253daeb3e6953e5e0d1d/runtimes/Components.cmake.in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121276/new/

https://reviews.llvm.org/D121276