[libcxx-commits] [PATCH] D120996: [libc++] Remove extension to support allocator<const T>

Reid Kleckner via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 9 10:07:04 PST 2022


rnk added a comment.

In D120996#3362137 <https://reviews.llvm.org/D120996#3362137>, @Quuxplusone wrote:

> This is the sort of thing to alert libc++-vendors about, right?

It seems this change is already causing problems for us. Google aims to uptake new versions of libc++ often. To support that, we are constantly testing new LLVM and libc++ versions ~daily. With this change, we can't continue testing new LLVM and libc++ versions. I estimate that it could take us a week to migrate our code, but that's a pretty soft estimate, I am not a domain expert. I would like to avoid a week long gap in our testing. Would you consider delaying this, setting up an opt-out configuration macro, or some other mitigation strategy to allow vendors to handle this transition gracefully?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120996/new/

https://reviews.llvm.org/D120996



More information about the libcxx-commits mailing list