[libcxx-commits] [libcxx] 54c4c01 - [libc++] Enable format_to and vformat_to tests even outside of Debug mode

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 9 09:38:41 PST 2022


Author: Louis Dionne
Date: 2022-03-09T12:38:30-05:00
New Revision: 54c4c01553e1ddcec654578a74081b341f82799b

URL: https://github.com/llvm/llvm-project/commit/54c4c01553e1ddcec654578a74081b341f82799b
DIFF: https://github.com/llvm/llvm-project/commit/54c4c01553e1ddcec654578a74081b341f82799b.diff

LOG: [libc++] Enable format_to and vformat_to tests even outside of Debug mode

These tests don't seem specific to the debug mode, so it makes sense to
run them even when the debug mode is disabled. When we run with the debug
mode enabled, we'll get the out-of-bounds checking that this test seems
to be concerned with.

Differential Revision: https://reviews.llvm.org/D121241

Added: 
    

Modified: 
    libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
    libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp b/libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
index 89e38f50ec9a0..1b6d94a4c140f 100644
--- a/libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
@@ -11,10 +11,6 @@
 // TODO FMT Evaluate gcc-11 status
 // UNSUPPORTED: gcc-11
 
-// The tests write fixed size buffer, make sure it remains in bounds.
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DEBUG=1
-// UNSUPPORTED: libcxx-no-debug-mode
-
 // <format>
 
 // template<class Out, class... Args>

diff  --git a/libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp b/libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
index 3f39fe27c4724..86cacf2ce9f66 100644
--- a/libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
@@ -11,10 +11,6 @@
 // TODO FMT Evaluate gcc-11 status
 // UNSUPPORTED: gcc-11
 
-// The tests write fixed size buffer, make sure it remains in bounds.
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DEBUG=1
-// UNSUPPORTED: libcxx-no-debug-mode
-
 // <format>
 
 // template<class Out>


        


More information about the libcxx-commits mailing list