[libcxx-commits] [PATCH] D121241: [libc++] Enable format_to and vformat_to tests even outside of Debug mode

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 9 09:37:37 PST 2022


Mordante accepted this revision as: Mordante.
Mordante added a comment.

In D121241#3368025 <https://reviews.llvm.org/D121241#3368025>, @Quuxplusone wrote:

>> it makes sense to run them even when the debug mode is disabled
>
> FWIW, that makes sense to me!

I dug back in the development history, but I don't recall why I added this. It indeed doesn't seem to be required.
LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121241/new/

https://reviews.llvm.org/D121241



More information about the libcxx-commits mailing list