[libcxx-commits] [PATCH] D121265: [libc++] [test] Add ranges_robust_against_copying_*.pass.cpp

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/libcxx/algorithms/ranges_robust_against_copying_comparators.pass.cpp:228
+    //(void)std::ranges::upper_bound(first, last, value, Less(&copies)); assert(copies == 0);
+    //(void)std::ranges::upper_bound(a, value, Less(&copies)); assert(copies == 0);
+
----------------
philnik wrote:
> I'd like `// (void)` a bit more.
For a permanent, informative comment, I'd 100% agree (but "don't comment out code").
These comments, though, are //meant// to be uncommented as we implement stuff, and be kinda ugly until then. Also, for consistency with the existing tests' commented-out stuff (e.g. in `niebloid.compile.pass.cpp` as well). So I'm leaving as-is. Let's make the question moot by implementing all these algorithms! ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121265/new/

https://reviews.llvm.org/D121265