[libcxx-commits] [PATCH] D118620: [SystemZ][z/OS] Build several exception derived classes as a separate library

[Fanbo Meng via Phabricator via libcxx-commits]

fanbo-meng added inline comments.


================
Comment at: libcxx/src/exceptions/exception_any.cpp:11
+
+namespace std {
+const char* bad_any_cast::what() const noexcept { return "bad any cast"; }
----------------
ldionne wrote:
> I think this should be using `_LIBCPP_BEGIN_NAMESPACE_STD_EXCEPTION`. Same for others below.
We used std namespace here to preserve the original behaviour of this class. The exception derived classes aren't really consistent with namespace as some uses `std::` and others uses `std::__1::`, so our use of  `_LIBCPP_BEGIN_NAMESPACE_STD_EXCEPTION ` is intended for those that originally uses `std::__1::` namespace, like `bad_weak_ptr` class.


================
Comment at: libcxx/utils/libcxx/test/config.py:377
             self.cxx.link_flags += ['-lc++']
+            if self.target_info.is_zos():
+                self.cxx.link_flags += ['-lc++_exception']
----------------
ldionne wrote:
> Please define a configuration file in the likes of `libcxx/test/configs/apple-libc++-shared.cfg.in` for testing. We're trying to move away from this `config.py`.
https://reviews.llvm.org/D118503#3354937 @muiez  will have another patch for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118620/new/

https://reviews.llvm.org/D118620