[libcxx-commits] [PATCH] D121231: [libc++] Remove raw call to debug handler from __char_traits_length_checked

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D121231#3368770 <https://reviews.llvm.org/D121231#3368770>, @EricWF wrote:

> Please don't change this. Google uses this hook to change the behavior of string_view internally. We're working to get rid of the patch, but this helper function was specifically put in place to allow for the patch.

@EricWF, sounds like Louis and I had two different interpretations of your request. :) Do you mean "Google wants the //name and signature// of `__char_traits_length_unchecked<_Traits>` to remain unchanged, please don't change it to `__assert_not_null`"? Or do you mean "Google wants the //implementation// of `__char_traits_length_unchecked<_Traits>` to remain unchanged, please don't change its body to use `_LIBCPP_ASSERT`"? I assumed you meant only the former; @ldionne's reply suggests that maybe you meant the latter. (IMVHO the latter is unreasonable, whereas the former is understandable but I agree Google should work with us to find a path forward and/or document what they need, because the current name-and-signature of `__char_traits_length_unchecked` is pretty weird.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121231/new/

https://reviews.llvm.org/D121231