[libcxx-commits] [PATCH] D121213: [libc++] Enable modernize-use-equals-delete

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D121213#3368838 <https://reviews.llvm.org/D121213#3368838>, @EricWF wrote:

> Are we sure this doesn't break the ABI because changing user declared constructors into delete constructors can do that, Can't it?

How could it change the ABI? The functions can never be called, and it doesn't change any type traits AFAIK. It's not like with `= default` that the type could be `trivially_something` after the change that it wasn't before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121213/new/

https://reviews.llvm.org/D121213