[libcxx-commits] [PATCH] D121265: [libc++] [test] Add ranges_robust_against_copying_*.pass.cpp

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision as: philnik.
philnik added a comment.

LGTM % nits.



================
Comment at: libcxx/test/libcxx/algorithms/ranges_robust_against_copying_comparators.pass.cpp:9-10
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: libcpp-no-incomplete-ranges
+
----------------
Shouldn't there also be `// UNSUPPORTED: libcpp-no-concepts`?


================
Comment at: libcxx/test/libcxx/algorithms/ranges_robust_against_copying_comparators.pass.cpp:228
+    //(void)std::ranges::upper_bound(first, last, value, Less(&copies)); assert(copies == 0);
+    //(void)std::ranges::upper_bound(a, value, Less(&copies)); assert(copies == 0);
+
----------------
I'd like `// (void)` a bit more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121265/new/

https://reviews.llvm.org/D121265