[libcxx-commits] [PATCH] D121241: [libc++] Enable format_to and vformat_to tests even outside of Debug mode

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
ldionne added a reviewer: Mordante.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

These tests don't seem specific to the debug mode, so it makes sense to
run them even when the debug mode is disabled. When we run with the debug
mode enabled, we'll get the out-of-bounds checking that this test seems
to be concerned with.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121241

Files:
  libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
  libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp


Index: libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
===================================================================
--- libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
+++ libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
@@ -11,10 +11,6 @@
 // TODO FMT Evaluate gcc-11 status
 // UNSUPPORTED: gcc-11
 
-// The tests write fixed size buffer, make sure it remains in bounds.
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DEBUG=1
-// UNSUPPORTED: libcxx-no-debug-mode
-
 // <format>
 
 // template<class Out>
Index: libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
===================================================================
--- libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
+++ libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
@@ -11,10 +11,6 @@
 // TODO FMT Evaluate gcc-11 status
 // UNSUPPORTED: gcc-11
 
-// The tests write fixed size buffer, make sure it remains in bounds.
-// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DEBUG=1
-// UNSUPPORTED: libcxx-no-debug-mode
-
 // <format>
 
 // template<class Out, class... Args>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121241.413893.patch
Type: text/x-patch
Size: 1156 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220308/db28a658/attachment-0001.bin>