[libcxx-commits] [PATCH] D121213: [libc++] Enable modernize-use-equals-delete

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Thanks for working on these cleanups! In general LGTM when the CI passes.



================
Comment at: libcxx/include/future:1628
-    _LIBCPP_INLINE_VISIBILITY
-    virtual ~__packaged_task_base() {}
     virtual void __move_to(__packaged_task_base*) _NOEXCEPT = 0;
----------------
As a note for other followup patches. I prefer these clang-tidy improvements not to do other cleanups in the same patch. I would prefer to see that in different patches. This makes reviewing them easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121213/new/

https://reviews.llvm.org/D121213