[libcxx-commits] [PATCH] D107500: [libc++][ranges] Implement `lazy_split_view`.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__ranges/lazy_split_view.h:194
+      } else if constexpr (__tiny_range<_Pattern>) {
+        // TODO(varconst): should be `ranges::find`.
+        __current() = std::find(std::move(__current()), __end, *__pbegin);
----------------
Quuxplusone wrote:
> var-const wrote:
> > Note: this is significant, though (I think) not enough to block this patch. Because the non-ranges version of the algorithm requires both iterators to have the same type, this will fail for ranges where `end()` returns a sentinel. (same applies to `mismatch` below)
> @philnik already has `mismatch` in progress: D117817
> I think we //should// block this patch until `ranges::find` is done. It can't be too hard for @philnik or someone else to tackle `find` next, and this way we don't build up a backlog of stuff to remember to go back and fix later.
`ranges::mismatch` should land within the next couple days. It's just waiting for @ldionne to be happy. I'll start with `ranges::find` next, since it's needed for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107500/new/

https://reviews.llvm.org/D107500