[libcxx-commits] [PATCH] D118503: [SystemZ][z/OS] Add ASCII and 32-bit variants for libc++.

Sean via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 7 14:46:25 PST 2022


SeanP added inline comments.


================
Comment at: libcxx/src/CMakeLists.txt:470
+# by external script thus, this step is not needed.
+if (NOT ZOS AND LIBCXX_INSTALL_SHARED_LIBRARY)
   install(TARGETS cxx_shared
----------------
SeanP wrote:
> I'd either wrap all of these install commands in one `if (not ZOS)` or get rid of them completely.
Just to be clear, I meant get rid of the "NOT ZOS AND" not the install commands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118503/new/

https://reviews.llvm.org/D118503



More information about the libcxx-commits mailing list