[libcxx-commits] [PATCH] D120996: [libc++] Remove extension to support allocator<const T>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D120996#3365559 <https://reviews.llvm.org/D120996#3365559>, @phosek wrote:

> After this change, gtest version that's used in LLVM is failing to build with:
>
>   In file included from /b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/unittest/googletest/include/gtest/gtest.h:56:
>   In file included from /b/s/w/ir/x/w/staging/llvm_build/./bin/../include/c++/v1/memory:810:
>   /b/s/w/ir/x/w/staging/llvm_build/./bin/../include/c++/v1/__memory/allocator.h:72:5: error: static_assert failed due to requirement '!is_const<const testing::MatcherInterface<const std::string &>>::value' "std::allocator does not support const types"
>       static_assert(!is_const<_Tp>::value, "std::allocator does not support const types");
>       ^             ~~~~~~~~~~~~~~~~~~~~~
>
> That broke compiler-rt runtimes whose tests use gtest: memprof, orc.
>
> You can see the full log here: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8820315548532839729/+/u/clang/build/stdout

Thanks for the heads up. I'll need to add more tests for `std::shared_ptr<T const>`, it seems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120996/new/

https://reviews.llvm.org/D120996