[libcxx-commits] [PATCH] D120982: [libcxxabi] Fix cmake order dependency wrt dllexporting

Mon Mar 7 12:35:12 PST 2022

ldionne added a comment.

In D120982#3365025 <https://reviews.llvm.org/D120982#3365025>, @mstorsjo wrote:

> In D120982#3364991 <https://reviews.llvm.org/D120982#3364991>, @mstorsjo wrote:
>
>> I was thinking of how to implement the next step for the libcxxabi<->libcxx merging for Windows (it works, but it has a number of quirks right now), and one possible path forward that I see could require further changes in how to set things up. So before telling people to migrate their setup to a new form, I think it'd be nice to wait a little if there's a different final form for LLVM 15.
>
> ... but I see the value of actually committing _something_ so it doesn't get forgotten. Do we have a list of things to add before the next branch so that it doesn't get lost in the unlikely event I don't manage to get back to it?

No, we don't. We generally try to avoid being in the situation where we need to remember to do something like that.

> Or commit those bits, commented out? Or just commit them as-is and then remove them later if the final solution ends up different?

Erhm, I guess I can comment the warning out, however it would be nice to soon have clarity on what's the better way of doing this instead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120982/new/

https://reviews.llvm.org/D120982