[libcxx-commits] [PATCH] D120982: [libcxxabi] Fix cmake order dependency wrt dllexporting

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D120982#3364775 <https://reviews.llvm.org/D120982#3364775>, @ldionne wrote:

> I will land this if CI passes, since this is on the critical path for a couple other changes, and we've agreed on the direction.

Actually, I would want to request that we defer the warning and release note for a little while. (We need to have it in place by the time LLVM 15 is finalized; the sooner before that it is settled, the better of course, but I would request to hold off of starting the deprecation cycle for it a little while.)

I was thinking of how to implement the next step for the libcxxabi<->libcxx merging for Windows (it works, but it has a number of quirks right now), and one possible path forward that I see could require further changes in how to set things up. So before telling people to migrate their setup to a new form, I think it'd be nice to wait a little if there's a different final form for LLVM 15.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120982/new/

https://reviews.llvm.org/D120982