[libcxx-commits] [PATCH] D121140: [libc++][AIX] AIX allows for changing permissions of symlinks

[Zarko Todorovski via Phabricator via libcxx-commits]

ZarkoCA created this revision.
ZarkoCA added reviewers: daltenty, hubert.reinterpretcast, libc++.
ZarkoCA added a project: libc++.
Herald added a subscriber: krytarowski.
Herald added a project: All.
ZarkoCA requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

The test fails on AIX due to it expecting an error as on Linux. However, as on
other non-Linux systems symlinks permissions are supported so expect an empty 
error code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D121140

Files:
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.permissions/permissions.pass.cpp


Index: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.permissions/permissions.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.permissions/permissions.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.permissions/permissions.pass.cpp
@@ -8,8 +8,6 @@
 
 // UNSUPPORTED: c++03
 
-// XFAIL: LIBCXX-AIX-FIXME
-
 // <filesystem>
 
 // void permissions(const path& p, perms prms,
@@ -164,7 +162,7 @@
         {perms::owner_all, perms::group_all, perm_options::remove},
     };
     for (auto const& TC : cases) {
-#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__)
+#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(_AIX)
         // On OS X symlink permissions are supported. We should get an empty
         // error code and the expected permissions.
         const auto expected_link_perms = TC.expected;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D121140.413563.patch
Type: text/x-patch
Size: 977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220307/16310aea/attachment.bin>