[libcxx-commits] [PATCH] D121110: [libc++] Add tests for the content of <cstddef>

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/libcxx/language.support/support.types/cstddef.compile.pass.cpp:18
+
+using NullptrT = std::nullptr_t;
----------------
The first was presumably a typo, but let's test both here, since otherwise we have no coverage for `std::nullptr_t`-in-C++03-mode.
Actually, you should probably just copy-paste the other test into this one and test //all// the things, e.g. `::max_align_t`.


================
Comment at: libcxx/test/std/language.support/support.types/cstddef.compile.pass.cpp:45
+#ifndef offsetof
+#   error "offsetoff() should be defined by <cstddef>"
+#endif
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121110/new/

https://reviews.llvm.org/D121110