[libcxx-commits] [PATCH] D121015: [libunwind] Add a _LIBUNWIND_VERSION macro

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 7 06:20:18 PST 2022


ldionne added a comment.

In D121015#3360735 <https://reviews.llvm.org/D121015#3360735>, @emaste wrote:

> LGTM (modulo the lint complaints)

I think the code would be inconsistent with surrounding code if I listened to them, so I'm tempted to ignore them instead. LMK if you disagree.

@mgorny Is this patch OK with you? Can you test it locally? I suspect that, in its current form, it's not going to quite work for you unless you have basically ToT libunwind headers installed on your system, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121015/new/

https://reviews.llvm.org/D121015



More information about the libcxx-commits mailing list