[libcxx-commits] [PATCH] D119585: [libc++] Remove experimental/algorithm

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added a subscriber: jloser.
Quuxplusone added a comment.
This revision now requires changes to proceed.

This is related to D119198 <https://reviews.llvm.org/D119198>: `std::experimental::search` works hand-in-hand with `std::experimental::boyer_moore_searcher` and company. We can't remove `std::experimental::boyer_moore_searcher` because we have not yet implemented C++17 `std::boyer_moore_searcher`
https://en.cppreference.com/w/cpp/utility/functional/boyer_moore_searcher
In this PR, @philnik observes that we //could// remove `std::experimental::search`, and just tell people to use `std::experimental::boyer_moore_searcher` with `std::search` instead.
In D119198 <https://reviews.llvm.org/D119198>, @jloser observed that we //could// remove `std::experimental::default_searcher`, and just tell people to use `std::default_searcher` with `std::experimental::search` instead.
But we //can't// remove all of the experimental searcher stuff in one fell swoop yet, because we haven't implemented the C++17 equivalents.

D119585 <https://reviews.llvm.org/D119585> seems to me slightly more acceptable than D119198 <https://reviews.llvm.org/D119198>... but guys, we should just implement the C++17 searchers already! @philnik, do you want to take that on?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119585/new/

https://reviews.llvm.org/D119585