[libcxx-commits] [PATCH] D120802: [libcxx] [test] Fix the classic_table test on Windows

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Mar 4 12:02:34 PST 2022


mstorsjo updated this revision to Diff 413091.
mstorsjo added a comment.

Updated as suggested; use `bool expected_foo` and check only that `bool(p[i] & F::foo) == expected_foo`, in general. For non-Windows, we can keep checking that all bits are set exactly as we want them.

Skip checking the `F::blank` bit for i < 14, it isn't set quite as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120802/new/

https://reviews.llvm.org/D120802

Files:
  libcxx/test/std/localization/locale.categories/category.ctype/facet.ctype.special/facet.ctype.char.statics/classic_table.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120802.413091.patch
Type: text/x-patch
Size: 4661 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220304/14f9a31b/attachment.bin>


More information about the libcxx-commits mailing list