[libcxx-commits] [PATCH] D120719: [runtimes] Always configure libc++abi before libc++

[Chris Bieneman via Phabricator via libcxx-commits]

beanz added a comment.

In D120719#3359971 <https://reviews.llvm.org/D120719#3359971>, @ldionne wrote:

> For example, we use `add_subdirectory()` and expect that it's going to set up some targets, which we then use after the call to `add_subdirectory()`. It's just how CMake works -- it is not sufficiently declarative to be fully order independent.

I'm curious what you mean by this. There are lots of ways that CMake allows you to reference targets before they are defined. The only things you really can't do are check if a target exists and query target properties. Many places where you do those two things can be converted to generator expressions and resolved at generation time instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120719/new/

https://reviews.llvm.org/D120719