[libcxx-commits] [PATCH] D120466: [libc++] Granularize <utility> includes
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 4 08:30:24 PST 2022
ldionne accepted this revision.
ldionne added a comment.
LGTM when CI passes. I think everybody's comments have been addressed now, except for @EricWF 's request for a design document. I spoke with Eric offline and explained why we were doing this, and why we didn't have a design document (TLDR we had Discord discussions about this and all ended up agreeing on the direction, but we didn't record it formally in a design doc). I think a design doc explaining the rationale for this change is a fair ask, however we can address it separately and I don't think this specific patch should be blocked on that task.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120466/new/
https://reviews.llvm.org/D120466
More information about the libcxx-commits
mailing list