[libcxx-commits] [PATCH] D120979: [libcxx] [test] Skip the get/put long_double_ru_RU tests on Glibc < 2.27

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp:60-68
+#if defined(_CS_GNU_LIBC_VERSION)
+    // Glibc before 2.27 used '.' instead of ',' as monetary decimal separator.
+    // Just skip the test (which gets marked as PASS, though) to avoid
+    // unnecessary churn for such old versions.
+    if (glibc_version_less_than("2.27")) {
+        std::cerr << "Skipping test\n";
+        return 0;
----------------
Quuxplusone wrote:
> This smells like the wrong way to do it, but I suppose we don't have an llvm-lit feature flag for this. Ping @ldionne — what do you think is the right approach here?
Yeah it's not the ideal fix unfortunately... We don't have a flag with the glibc version at that level. (And if we had, would we need to do e.g. `// UNSUPPORTED: glibc-2.11, glibc-2.12, glibc-2.13, glibc-2.14, ...`?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120979/new/

https://reviews.llvm.org/D120979