[libcxx-commits] [PATCH] D120982: [libcxxabi] Fix cmake order dependency wrt dllexporting

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Like I said in D120719 <https://reviews.llvm.org/D120719>, I am not fond of this approach because it preserves the circular dependency between libc++ and libc++abi. My primary goal is that libc++abi doesn't have to have too much knowledge about how libc++ is configured (ideally it would require no such knowledge).

To this end, we could either:

1. Ask Windows vendors to bite the bullet and start defining `LIBCXXABI_HERMETIC_STATIC_LIBRARY` manually, or
2. Set `LIBCXXABI_HERMETIC_STATIC_LIBRARY` to `ON` by default on Windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120982/new/

https://reviews.llvm.org/D120982