[libcxx-commits] [PATCH] D120719: [runtimes] Always configure libc++abi before libc++

Fri Mar 4 02:58:47 PST 2022

mstorsjo added a comment.

In D120719#3358350 <https://reviews.llvm.org/D120719#3358350>, @ldionne wrote:

> Play around with the MinGW configuration based on discussion with @mstorsjo.
>
> I suspect this is going to pass in the CI, but it will also cause anyone building for WIN32
> to suddenly export symbols from their static libc++abi unless they use -DLIBCXXABI_HERMETIC_STATIC_LIBRARY=ON.

I posted a different patch that fixes the issue without breaking users existing workflows without warning in D120982 <https://reviews.llvm.org/D120982>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120719/new/

https://reviews.llvm.org/D120719