[libcxx-commits] [PATCH] D120317: [libcxx] [test] Fix get/put long_double_ru_RU on Glibc, FreeBSD and Windows

[Mikael Holmén via Phabricator via libcxx-commits]

uabelho added a comment.

In D120317#3359332 <https://reviews.llvm.org/D120317#3359332>, @mstorsjo wrote:

> What glibc version do you have? As you're on RHEL, I would expect an older one (mine is on Ubuntu 20.04, with glibc 2.31). There seems to be differences in most fields, in particular in `mon_decimal_point` here. We already have some conditionals due to the fact that `currency_symbol` differs for ru_RU.UTF-8 in various glibc versions (apparently with the new form appearing in 2.24), but we never had any glibc conditionals for the differing `mon_decimal_point`. As that probably would require quite intrusive changes to the test, I guess it's probably best to make the test bail out on such older versions (as it just has been XFAILed forever on that platform before anyway).

Seems like it 2.17. ldd on the bult binary says e.g. 
	libc.so.6 => /lib64/libc.so.6 (0x00007fc160eed000)
and then
 -> /lib64/libc.so.6
GNU C Library (GNU libc) stable release version 2.17, by Roland McGrath et al.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120317/new/

https://reviews.llvm.org/D120317