[libcxx-commits] [PATCH] D120064: Fix EBO on std::optional and std::variant when targeting the MSVC ABI

Fri Mar 4 00:11:12 PST 2022

mstorsjo added a comment.

In D120064#3359254 <https://reviews.llvm.org/D120064#3359254>, @hans wrote:

> In D120064#3352471 <https://reviews.llvm.org/D120064#3352471>, @ldionne wrote:
>
>> Yeah, I agree with that. We could update the Windows row in https://libcxx.llvm.org/#platform-and-compiler-support to say that the ABI is unstable -- would that be reasonable?
>
> Sounds reasonable to me.

At least for the MSVC/MSABI variant of it - most of these issues don't hit the mingw configuration. In the mingw configuration, there's also more use of the library as a platform library - where we'd preferrably avoid continuous ABI breakage if possible (but where it probably still can be tolerated if deemed necessary).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120064/new/

https://reviews.llvm.org/D120064