[libcxx-commits] [PATCH] D120719: [runtimes] Always configure libc++abi before libc++

[Petr Hosek via Phabricator via libcxx-commits]

phosek added a subscriber: beanz.
phosek added inline comments.


================
Comment at: runtimes/CMakeLists.txt:74
   if(NOT DEFINED LLVM_BUILD_COMPILER_RT OR LLVM_BUILD_COMPILER_RT)
     list(INSERT runtimes 0 ${compiler_rt_path})
   endif()
----------------
We similarly reorder compiler-rt here so these blocks should probably be moved next to each other.

If we decide to go take this direction, I wonder if we should have a canonical order for runtimes rather than reodering them ad-hoc? I remember having that discussion with @beanz in the past and he argued against it but I don't remember what the reason was, @beanz do you remember?

A potential issue I can think of is if downstream users have their own runtimes (that is doing `-DLLVM_ENABLE_RUNTIMES=libcxx;foo`), there's currently no way for them to specify the order and if we start relying on a canonical ordering, we may inadvertently break them, but I'm not sure if that's a practical concern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120719/new/

https://reviews.llvm.org/D120719