[libcxx-commits] [PATCH] D120448: [libc++][AIX][test] Enable put_double/long_double locale tests

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this, I like the direction it's going.
Please update the summary with the current direction.



================
Comment at: libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp:8957
                                     cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), ios, '*', v);
                                     std::string ex(str, iter.base());
+                                    assert(ex == "-" + inf);
----------------
Please make sure you rebase your next iteration of this patch. I just committed a change to this line. I like to see the CI pass with those conflicts resolved.


================
Comment at: libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp:10770
                                     std::string ex(str, iter.base());
-                                    assert(ex == "nan**********************");
+                                    assert(ex == nan + nan_padding25 );
                                     assert(ios.width() == 0);
----------------
Please check the rest of the patch for similar unneeded spaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120448/new/

https://reviews.llvm.org/D120448