[libcxx-commits] [PATCH] D120799: [libcxx] [test] Fix get_string_en_US, get_long_double_en_US for Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_en_US.pass.cpp:64
+}
+
 int main(int, char**)
----------------
Quuxplusone wrote:
> Could this go in `LocaleHelpers` instead? Or would that be problematic because the behavior depends on the specific locale too? (Or is that a good thing because it indicates that this function should actually be named `currency_negate_en_US` or something?)
> 
> Worth thinking about, but IMHO not worth my blocking this PR over. :)
Yeah it could go there with such a name too - making all the calls to it slightly longer and more verbose though. But possibly still tolerable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120799/new/

https://reviews.llvm.org/D120799