[libcxx-commits] [PATCH] D120889: [libcxx] [test] Fix the get/put long_double_zh_CN tests on Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo updated this revision to Diff 412761.
mstorsjo added a comment.

Applied most of the suggestions; renamed variables for clarity, using a locale helper for the symbol, inlined the padding string expansion.

Still using separate variables for `currency_symbol` instead of inlineing the call to the multistring locale helper, because there's no operator for e.g. `operator+(MultiString, const char*)` that would reduce the multistring implicitly to the desired string type. Using ifdefs for the definition of the international name with/without trailing space.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120889/new/

https://reviews.llvm.org/D120889

Files:
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp
  libcxx/test/support/locale_helpers.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120889.412761.patch
Type: text/x-patch
Size: 24951 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220303/7d6171b7/attachment-0001.bin>