[libcxx-commits] [PATCH] D119628: [libc++] Don't return alloc_size - 1 in __recommend to add 1 when allocating

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D119628#3357180 <https://reviews.llvm.org/D119628#3357180>, @EricWF wrote:

> I'm not OK with this change given that the description indicates a lack of understanding of the current situation.

Then tell me what I'm not understanding.

In D119628#3357187 <https://reviews.llvm.org/D119628#3357187>, @EricWF wrote:

> I also agree with @ldionne's comment about this being potentially ABI breaking because of how std::string is externally instantiated.

Can you give a scenario where that is the case? Just saying '//could// be an ABI break' isn't an argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119628/new/

https://reviews.llvm.org/D119628