[libcxx-commits] [PATCH] D120684: [libc++] Define _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER whenever we enable warnings in the test suite

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:17
 
-#define _LIBCPP_DISABLE_DEPRECATION_WARNINGS
+// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
----------------
How many of the diffs are just refactoring `#define` into `ADDITIONAL_COMPILER_FLAGS: -D`? I don't think that's related to the point of this patch; I also think it's uncontroversial and you could ship it right now. Or am I missing something?

(Further down, I see some where the `#define` was separated from the `REQUIRES` by several lines of code. I suggest moving it up to the line immediately after the `REQUIRES`.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120684/new/

https://reviews.llvm.org/D120684