[libcxx-commits] [PATCH] D120889: [libcxx] [test] Fix the get/put long_double_zh_CN tests on Windows
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 3 03:57:43 PST 2022
mstorsjo created this revision.
mstorsjo added reviewers: Quuxplusone, Mordante.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.
This is an initial, working version, but this doesn't use
the new `locale_helpers.h` header. It'd be straightforward to add
a similar helper for e.g. `currency_symbol_zh_CN()`, but we'd
still need the ifdefs for handling the difference in trailing space
after the text version (`"CNY"` vs `"CNY "`) and the difference
in the padding strings - and the padding strings are tied to exactly
how many utf8 bytes each unicode code point occupies. (I guess
technically such padding shouldn't look at the byte length of an
utf8 string, but at how many characters it really representes, too,
but that's way out of scope for this patch).
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D120889
Files:
libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp
libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120889.412666.patch
Type: text/x-patch
Size: 23913 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220303/648dc269/attachment-0001.bin>
More information about the libcxx-commits
mailing list