[libcxx-commits] [PATCH] D120317: [libcxx] [test] Fix get/put long_double_ru_RU on Glibc, FreeBSD and Windows

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

LGTM % one last comment! I think `MultiStringType` really cleaned it up nicely.



================
Comment at: libcxx/test/support/locale_helpers.h:48-54
+#if defined(_CS_GNU_LIBC_VERSION) || defined(__FreeBSD__)
+#if defined(_CS_GNU_LIBC_VERSION)
+  if (glibc_version_less_than("2.27"))
+    return in;
+#endif
+  return convert_thousands_sep(in, L'\u202F');
+#elif defined(_WIN32)
----------------
I think this will be easier to grok. (It follows the same pattern as lines 76-83 below.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120317/new/

https://reviews.llvm.org/D120317