[libcxx-commits] [PATCH] D118616: [libc++] Use -I instead of -isystem to include headers in the test suite

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM if CI is passing, however I would much rather rip out the `ext/` headers from tests and avoid introducing the `_LIBCXX_MODULES_BUILD` macro.

FWIW, this is going to interact with D120684 <https://reviews.llvm.org/D120684> almost certainly. The second one to land his patch is probably going to have additional work to do. If CI passes on your patch, I don't mind you shipping it as-is, and then tackling the removal of `_LIBCXX_MODULES_BUILD` separately, just for the sake of making progress on this (and allowing me to start fixing any remaining issues with my patch).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118616/new/

https://reviews.llvm.org/D118616