[libcxx-commits] [PATCH] D120831: [libc++] Remove the deprecated <ext/hash_set> and <ext/hash_map>.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Here's one possible alternative, which would make everyone happy (I think):

1. Move `<ext/hash_map>` & friends to another directory OUTSIDE of `libcxx/include`.
2. When a CMake setting like `LIBCXX_INSTALL_LEGACY_HASH_MAP` is enabled, install it as part of `install-cxx-headers`. By default, this is OFF, but vendors who want to keep it can turn it on.
3. Remove everything else related to those headers from our code base (i.e. take most of this patch).

That way, vendors could retain the headers with minimal effort, but we'd still get the benefit of not having to care about them anymore.

The lack of benefit for removing them has sometimes been brought up as an argument for keeping them around. I've never pushed back on that, since it's pretty reasonable (why cause pain for no reason?). However, given that now this is causing us problems (with D118616 <https://reviews.llvm.org/D118616>), I think we have a good reason to act on those headers.

Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120831/new/

https://reviews.llvm.org/D120831