[libcxx-commits] [PATCH] D120797: [libcxx] [test] Fix the collate compare test for Glibc, Windows and FreeBSD

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

I'm not 100% happy with the wording of the comments "Apple seems to collate lexicographically" and "Glibc, Windows and FreeBSD collate ignoring case here" — I think "lexicographically" is ambiguous. Lexicographical order unambiguously describes how to order variable-length sequences of elements //given that you know how to compare two elements//, but it doesn't imply anything about the way in which you compare those elements. A dictionary that sorts "run, Runescape, runt" is still //lexicographically// ordered; it just happens to collate `r` and `R` together.

How about "Apple's default collation is case-sensitive" and "Glibc, Windows, and FreeBSD's default collation is case-insensitive"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120797/new/

https://reviews.llvm.org/D120797