[libcxx-commits] [PATCH] D120798: [libcxx] [test] Fix en_US money locale formatting tests on Windows

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

Looks reasonable to me. I do still wonder if it would be profitable to introduce a macro throughout instead of repeating the less-greppable `#ifdef _WIN32`; something like

  ASSERT_ON_WIN32(ex == L"   (USD1,234,567.89)");
  ASSERT_EXCEPT_WIN32(ex == L"   -USD 1,234,567.89");

or even something like

  ASSERT_EQ_WIN32(ex, L"   -USD 1,234,567.89", L"   (USD1,234,567.89)");

(although that's a terrible name and I can't think of a good one).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120798/new/

https://reviews.llvm.org/D120798