[libcxx-commits] [PATCH] D120799: [libcxx] [test] Fix get_string_en_US, get_long_double_en_US for Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added reviewers: Mordante, Quuxplusone.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

In the en_US locale on Windows, negative currency amounts is formatted
as "($0.01)" instead of "-$0.01".

This is the same issue as D120798 <https://reviews.llvm.org/D120798>, but with a different fix strategy.

To avoid excessive amounts of ifdefs to get the right string form for
each of them, just ifdef out groups of tests that test negative values.
(This keeps the number of ifdefs needed more reasonable, as there's 2-3
strings per ifdef in this case.)

Alternatively, we could just keep the XFAIL without the FIXME part and
conclude that this is known to be different and we don't want the churn
to fix it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120799

Files:
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_en_US.pass.cpp
  libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_string_en_US.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120799.412351.patch
Type: text/x-patch
Size: 17369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220302/40b0e6c2/attachment.bin>