[libcxx-commits] [PATCH] D120797: [libcxx] [test] Explain and clarify a Windows XFAIL

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added reviewers: Mordante, Quuxplusone.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

In clang-cl/DLL configurations, the test is hit by
https://llvm.org/PR41018 (making the test fail to link).

For other Windows configurations, the collation result is different
from the expected reference (which seems to be the Apple C library
behaviour), just like Glibc also seems to differ.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120797

Files:
  libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp


Index: libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
@@ -23,7 +23,12 @@
 // Glibc seems to collate files differently from the way Apple's C library does it.
 // XFAIL: target={{.*}}-linux-gnu{{.*}}
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
+// https://llvm.org/PR41018
+// XFAIL: windows-dll && msvc
+
+// Windows also collates differently than the Apple C library way, that this
+// test is written for.
+// XFAIL: windows
 
 // XFAIL: LIBCXX-AIX-FIXME
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120797.412348.patch
Type: text/x-patch
Size: 787 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220302/2d890a76/attachment.bin>