[libcxx-commits] [PATCH] D119687: [libc++] [test] Improve the tests for std::{begin, end}(valarray).

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

In D119687#3319906 <https://reviews.llvm.org/D119687#3319906>, @EricWF wrote:

> The test suite has typically been structured so that each overload gets its own test file. Your changes undo this. Can you state why you believe this to be an improvement?

We exercise judgement regarding this. We do try to split different functions and overloads into separate files, except when it provides little value.

FWIW, I'd rather keep begin and end tests in different files (ditto in D119677 <https://reviews.llvm.org/D119677>), but that's non-blocking. I also don't see a reduction in test coverage, so LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119687/new/

https://reviews.llvm.org/D119687