[libcxx-commits] [PATCH] D128646: [libc++] Use __is_exactly_{input, forward}_iterator

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ comments.



================
Comment at: libcxx/include/deque:1357
         void assign(_InputIter __f, _InputIter __l,
-                    typename enable_if<__is_cpp17_input_iterator<_InputIter>::value &&
-                                      !__is_cpp17_random_access_iterator<_InputIter>::value>::type* = 0);
----------------
Previously, this would accept input iterators, forward iterators, and bidirectional iterators. After the change, it would only accept input iterators.

If no test fails after making this change, we need to add a test case.


================
Comment at: libcxx/include/deque:1762
-                               typename enable_if<__is_cpp17_input_iterator<_InputIter>::value &&
-                                                 !__is_cpp17_random_access_iterator<_InputIter>::value>::type*)
 {
----------------
Same comment as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128646/new/

https://reviews.llvm.org/D128646