[libcxx-commits] [PATCH] D127834: [libc++][ranges] Implement `ranges::stable_sort`.

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jun 30 04:59:42 PDT 2022


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: libcxx/test/std/algorithms/alg.sorting/alg.sort/stable.sort/ranges.stable.sort.pass.cpp:187
+      int a;
+      bool operator==(const A&) const = default;
+    };
----------------
var-const wrote:
> philnik wrote:
> > Isn't this be unnecessary and even counter-productive?
> It's used to compare check the `in` array after it's sorted:
> ```
> assert((in == std::array{A{1}, A{2}, A{3}}));
> ```
> Perhaps I'm missing something?
Ah OK, I missed that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127834/new/

https://reviews.llvm.org/D127834



More information about the libcxx-commits mailing list