[libcxx-commits] [PATCH] D128568: [runtimes] adds llvm-libgcc to the list of runtimes to be sorted

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: runtimes/CMakeLists.txt:18-25
 set(LLVM_ALL_RUNTIMES "libc;libunwind;libcxxabi;libcxx;compiler-rt;openmp")
 set(LLVM_ENABLE_RUNTIMES "" CACHE STRING
   "Semicolon-separated list of runtimes to build (${LLVM_ALL_RUNTIMES}), or \"all\".")
 if(LLVM_ENABLE_RUNTIMES STREQUAL "all" )
   set(LLVM_ENABLE_RUNTIMES ${LLVM_ALL_RUNTIMES})
 endif()
 include(SortSubset)
----------------
I'd like to suggest this instead:

```
set(LLVM_DEFAULT_RUNTIMES "libc;libunwind;libcxxabi;libcxx;compiler-rt;openmp")
set(LLVM_ALL_RUNTIMES "${LLVM_DEFAULT_RUNTIMES};llvm-libgcc")
set(LLVM_ENABLE_RUNTIMES "" CACHE STRING
  "Semicolon-separated list of runtimes to build (which must be in ${LLVM_ALL_RUNTIMES}), or \"all\", in which case the following set of default runtimes will be used: ${LLVM_DEFAULT_RUNTIMES}.")
if(LLVM_ENABLE_RUNTIMES STREQUAL "all" )
  set(LLVM_ENABLE_RUNTIMES ${LLVM_DEFAULT_RUNTIMES})
endif()
include(SortSubset)
sort_subset("${LLVM_ALL_RUNTIMES}" "${LLVM_ENABLE_RUNTIMES}" LLVM_ENABLE_RUNTIMES)
```

This opens the door to adding other "alternative" runtimes that are not selected by default when one uses `all`. Note that `all` becomes a slight misnomer, but it seems like it already is anyway cause there exists some runtimes (such as `llvm-libgcc`) that are not selected by `all`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128568/new/

https://reviews.llvm.org/D128568