[libcxx-commits] [PATCH] D128661: [libc++] Re-add transitive includes that had been removed since LLVM 14

[Stephan Bergmann via Phabricator via libcxx-commits]

sberg added a comment.

I think this starts to cause circular dependencies now when building libcxx:

  [3578/6436] Building CXX object projects/libcxx/src/CMakeFiles/cxx_shared.dir/chrono.cpp.o
  FAILED: projects/libcxx/src/CMakeFiles/cxx_shared.dir/chrono.cpp.o 
  /usr/lib64/ccache/clang++ -DLIBCXX_BUILDING_LIBCXXABI -D_GNU_SOURCE -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_DISABLE_NEW_DELETE_DEFINITIONS -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_LINK_PTHREAD_LIB -D_LIBCPP_LINK_RT_LIB -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/sbergman/llvm/build/projects/libcxx/src -I/home/sbergman/github.com/llvm/llvm-project/libcxx/src -I/home/sbergman/llvm/build/include -I/home/sbergman/github.com/llvm/llvm-project/llvm/include -I/home/sbergman/llvm/build/include/c++/v1 -I/home/sbergman/llvm/build/include/x86_64-unknown-linux-gnu/c++/v1 -I/home/sbergman/github.com/llvm/llvm-project/libcxxabi/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers  -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O2 -g  -fPIC -UNDEBUG -gsplit-dwarf -faligned-allocation -nostdinc++ -fvisibility-inlines-hidden -fvisibility=hidden -Wall -Wextra -W -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wformat-nonliteral -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-error -std=c++20 -MD -MT projects/libcxx/src/CMakeFiles/cxx_shared.dir/chrono.cpp.o -MF projects/libcxx/src/CMakeFiles/cxx_shared.dir/chrono.cpp.o.d -o projects/libcxx/src/CMakeFiles/cxx_shared.dir/chrono.cpp.o -c /home/sbergman/github.com/llvm/llvm-project/libcxx/src/chrono.cpp
  In file included from /home/sbergman/github.com/llvm/llvm-project/libcxx/src/chrono.cpp:17:
  In file included from /home/sbergman/llvm/build/include/c++/v1/system_error:151:
  In file included from /home/sbergman/llvm/build/include/c++/v1/string:550:
  In file included from /home/sbergman/llvm/build/include/c++/v1/string_view:222:
  In file included from /home/sbergman/llvm/build/include/c++/v1/algorithm:1179:
  In file included from /home/sbergman/llvm/build/include/c++/v1/__algorithm/nth_element.h:14:
  In file included from /home/sbergman/llvm/build/include/c++/v1/__algorithm/sort.h:15:
  In file included from /home/sbergman/llvm/build/include/c++/v1/__algorithm/partial_sort.h:23:
  In file included from /home/sbergman/llvm/build/include/c++/v1/__algorithm/shuffle.h:20:
  In file included from /home/sbergman/llvm/build/include/c++/v1/iostream:41:
  In file included from /home/sbergman/llvm/build/include/c++/v1/ios:221:
  In file included from /home/sbergman/llvm/build/include/c++/v1/__locale:19:
  In file included from /home/sbergman/llvm/build/include/c++/v1/mutex:191:
  /home/sbergman/llvm/build/include/c++/v1/__mutex_base:204:9: error: use of undeclared identifier '__throw_system_error'
          __throw_system_error(EPERM, "unique_lock::lock: references null mutex");
          ^
  [...]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128661/new/

https://reviews.llvm.org/D128661