[libcxx-commits] [PATCH] D128348: [SystemZ][z/OS] Add support for an external unwinder
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Jun 27 15:04:14 PDT 2022
ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
I think the idea behind this patch is interesting and useful, however I'd like to model what we do for selecting the ABI library from libc++ here. We should have a `HandleUnwindLibrary.cmake` file that will create interface targets, and we can then link against those from libc++abi directly. Let's avoid introducing even more options like `LIBCXXABI_EXTERNAL_UNWIND_SOURCE_DIR` and `LIBCXXABI_EXTERNAL_UNWIND_LIB_NAME` -- instead let's put the logic for how to handle z/OS's unwind library in `HandleUnwindLibrary.cmake` directly.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits