[libcxx-commits] [PATCH] D128671: [libc++][format] Improve pointer formatters.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This changes the implementation of the formatter. Instead of inheriting
from a specialized parser all formatters will use the same generic
parser. This reduces the binary size.

The new parser contains some additional fields only used in the chrono
formatting. Since this doesn't change the size of the parser the fields
are in the generic parser. The parser is designed to fit in 128-bit,
making it cheap to pass by value.

The new format function is a const member function. This isn't required
by the Standard yet, but it will be after LWG-3636 is accepted.
Additionally P2286 <https://reviews.llvm.org/P2286> adds a formattable concept which requires the member
function to be const qualified in C++23. This paper is likely to be
accepted in the 2022 July plenary.

This is based on D125606 <https://reviews.llvm.org/D125606>. That commit did the groundwork and did similar
changes for the string formatters.

Depends on D128139 <https://reviews.llvm.org/D128139>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D128671

Files:
  libcxx/include/__format/formatter_pointer.h
  libcxx/include/__format/parser_std_format_spec.h
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_pointer.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D128671.440307.patch
Type: text/x-patch
Size: 17203 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220627/b53909b2/attachment-0001.bin>