[libcxx-commits] [PATCH] D128661: [libc++] Re-add transitive includes that had been removed since LLVM 14

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

A said before I'm not completely happy we have to take this approach, but I understand why it's important for some users of libc++. So I don't have objections against this approach. But I really would like the CI to test the new macro.



================
Comment at: libcxx/docs/ReleaseNotes.rst:103
+  please compile your code with ``_LIBCPP_REMOVE_TRANSITIVE_INCLUDES`` defined
+  and fix any compilation error resulting from missing includes.
 
----------------
Can we use `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES` in the CI, that way we know that removing the includes guarded by this macro doesn't bit rot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128661/new/

https://reviews.llvm.org/D128661